Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: disable plugin in default and persist file in specified dir (#7087) #7142

Merged
merged 5 commits into from
Sep 28, 2023
Merged

security: disable plugin in default and persist file in specified dir (#7087) #7142

merged 5 commits into from
Sep 28, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7087

What problem does this PR solve?

Issue Number: Close #7094

What is changed and how does it work?

  • Load plugin and persist file in specified dir [config data dir]
  • Judge persist file name rather than delete this interface to keep compatible
  • Support a config to decide whether to enable the plugin

Check List

Tests

  • Unit test

Release note

Add compile configuration to enable `Load Plugin` and disable `Load Plugin` by default. Need to `make pd-server-plugin` when want to enable plugin

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Sep 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 22, 2023
Merged
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 22, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 27, 2023

@HuSharp plz fix the conflicts.

@HuSharp
fix
e08e218 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7087-to-release-7.1 branch from b130fdf to e08e218 Compare September 27, 2023 10:20
@HuSharp
fix
09fc5da 
Signed-off-by: husharp <[email protected]>
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Files Coverage Δ
server/api/admin.go 61.76% <ø> (ø)
server/replication/replication_mode.go 78.94% <100.00%> (ø)
server/handler.go 52.08% <0.00%> (-0.30%) ⬇️
server/api/plugin_disable.go 20.00% <20.00%> (ø)
server/server.go 73.90% <33.33%> (-0.40%) ⬇️
server/util.go 57.37% <42.85%> (-1.89%) ⬇️

... and 25 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2023
@rleungx
Copy link
Member

rleungx commented Sep 28, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c01e797

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 905d8ff into tikv:release-7.1 Sep 28, 2023
15 checks passed
@HuSharp HuSharp deleted the cherry-pick-7087-to-release-7.1 branch September 28, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees

@HuSharp HuSharp

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @nolouch @rleungx @lhy1024 @HuSharp